Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localwind #1026

Merged
merged 11 commits into from
Oct 22, 2021
Merged

Added localwind #1026

merged 11 commits into from
Oct 22, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 14, 2021

Signed-off-by: Nate Koenig nate@openrobotics.org

This is an up to #1016.

I've added noise to each tile that has local wind, and spread out the local wind across more tile so that the changes are gradual.

To Test:

  1. You'll need Fortress.
  2. IGNITION_VERSION=fortress catkin_make install
  3. ign launch -v 4 cloudsim_sim.ign worldName:=finals_qual_demo levels:=false robotName1:=X1 robotConfig1:=X1_SENSOR_CONFIG_1
  4. Move the robot to one of the tiles with local wind.

Nate Koenig added 5 commits October 12, 2021 14:03
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from iche033 October 20, 2021 15:29
Nate Koenig added 3 commits October 20, 2021 10:54
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from iche033 October 20, 2021 18:11
@nkoenig nkoenig changed the base branch from door to fortress October 20, 2021 18:52
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@iche033
Copy link
Contributor

iche033 commented Oct 20, 2021

thanks the crash is fixed. When I move the robot to tiles near the staging area I don't see these debug msgs though.

It seems like the VisibilityTable does not contain those coordinates. I did a quick check visualizing comms and it shows that only the staging area is covered

finals_qual_demo_comms

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig
Copy link
Contributor Author

nkoenig commented Oct 21, 2021

I regenerated the comms model in 01a712d

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me now. Just one minor comment on missing tiles.

</local_wind>

<local_wind>
<tile>14</tile>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tile_12, tile_13, and tile_14 do not exist in this world

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from iche033 October 22, 2021 16:18
@nkoenig nkoenig merged commit a6312f7 into fortress Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants